tests: cover native module pk3 loading guards#263
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
com_nativeLibraryExtractPk3.vm/native_cache/, direct/vm/modules fallback order, explicit-path no-fallback behavior, disk length+CRC cache reuse, direct cache writes, diagnostics, andFS_LoadLibraryprobing pk3 cache before loose files.luaL_loadfiletoFS_ReadFile+luaL_loadbufferfor scripts stored in pk3s.Test files added/updated
tests/scripts/test_native_module_regressions.sh.test_native_module_regressionsinCMakeLists.txt.tests/README.mdvalidation list.Why this reduces regression risk
Native module loading is a core mod/full-conversion path, and failures can silently break pk3-only native UI/game modules. These deterministic guards protect the intended extraction/cache invariants without requiring real game data, native libraries, or dlopen-capable fixtures.
Validation
tests/scripts/test_native_module_regressions.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_native_module_regressions --output-on-failure